Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated libsaibcm to fix libsaithrift compile issue on BRCM image #10852

Merged

Conversation

vmittal-msft
Copy link
Contributor

@vmittal-msft vmittal-msft commented May 16, 2022

Why I did it

To fix compilation issue on libsaithrift on brcm image

How I did it

Updated libsaibcm to install SAI experimental files at correct location

How to verify it

Compilation goes fine after the change. Also loaded the image on DUT to verify basic things.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Updated libsaibcm to fix libsaithrift compile issue on BRCM image

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

xumia
xumia previously approved these changes May 17, 2022
kcudnik
kcudnik previously approved these changes May 17, 2022
@vmittal-msft vmittal-msft dismissed stale reviews from kcudnik and xumia via cb0e595 May 17, 2022 23:29
@vmittal-msft vmittal-msft force-pushed the vmittal/libsaithrift-fix branch from 9d71035 to cb0e595 Compare May 17, 2022 23:29
@vmittal-msft vmittal-msft requested a review from qiluo-msft as a code owner May 17, 2022 23:29
@vmittal-msft vmittal-msft force-pushed the vmittal/libsaithrift-fix branch from cb0e595 to 1e8135a Compare May 18, 2022 15:06
@vmittal-msft vmittal-msft force-pushed the vmittal/libsaithrift-fix branch from 1e8135a to 7968d0b Compare May 18, 2022 21:02
slave.mk Show resolved Hide resolved
@vmittal-msft vmittal-msft merged commit f7882b3 into sonic-net:master May 19, 2022
@vmittal-msft vmittal-msft deleted the vmittal/libsaithrift-fix branch May 19, 2022 18:15
liushilongbuaa pushed a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Jun 20, 2022
…anch

Related work items: #52, #71, #73, #75, #77, sonic-net#1306, sonic-net#1588, sonic-net#1991, sonic-net#2031, sonic-net#2040, sonic-net#2053, sonic-net#2066, sonic-net#2069, sonic-net#2087, sonic-net#2107, sonic-net#2110, sonic-net#2112, sonic-net#2113, sonic-net#2117, sonic-net#2124, sonic-net#2125, sonic-net#2126, sonic-net#2128, sonic-net#2130, sonic-net#2131, sonic-net#2132, sonic-net#2133, sonic-net#2134, sonic-net#2135, sonic-net#2136, sonic-net#2137, sonic-net#2138, sonic-net#2139, sonic-net#2140, sonic-net#2143, sonic-net#2158, sonic-net#2161, sonic-net#2233, sonic-net#2243, sonic-net#2250, sonic-net#2254, sonic-net#2260, sonic-net#2261, sonic-net#2267, sonic-net#2278, sonic-net#2282, sonic-net#2285, sonic-net#2288, sonic-net#2289, sonic-net#2292, sonic-net#2294, sonic-net#8887, sonic-net#9279, sonic-net#9390, sonic-net#9511, sonic-net#9700, sonic-net#10025, sonic-net#10322, sonic-net#10479, sonic-net#10484, sonic-net#10493, sonic-net#10500, sonic-net#10580, sonic-net#10595, sonic-net#10628, sonic-net#10634, sonic-net#10635, sonic-net#10644, sonic-net#10670, sonic-net#10691, sonic-net#10716, sonic-net#10731, sonic-net#10750, sonic-net#10751, sonic-net#10752, sonic-net#10761, sonic-net#10769, sonic-net#10775, sonic-net#10776, sonic-net#10779, sonic-net#10786, sonic-net#10792, sonic-net#10793, sonic-net#10800, sonic-net#10806, sonic-net#10826, sonic-net#10839, sonic-net#10840, sonic-net#10842, sonic-net#10844, sonic-net#10847, sonic-net#10849, sonic-net#10852, sonic-net#10865, sonic-net#10872, sonic-net#10877, sonic-net#10886, sonic-net#10889, sonic-net#10903, sonic-net#10904, sonic-net#10905, sonic-net#10913, sonic-net#10914, sonic-net#10916, sonic-net#10919, sonic-net#10925, sonic-net#10926, sonic-net#10929, sonic-net#10933, sonic-net#10934, sonic-net#10937, sonic-net#10941, sonic-net#10947, sonic-net#10952, sonic-net#10953, sonic-net#10957, sonic-net#10959, sonic-net#10971, sonic-net#10972, sonic-net#10980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants